-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force update rust on the CI #6025
Conversation
2ff078b
to
19c8c79
Compare
b458208
to
15b1113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios.yml
line 10 at r1 (raw file):
- ios/.swiftformat - ios/**/*.swift - ios/**/*.xctestplan
We should run these tests if Cargo.toml
in the root is upgraded too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios.yml
line 10 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
We should run these tests if
Cargo.toml
in the root is upgraded too.
That way we can know if this breaks iOS builds the next time we update rust 😺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
.github/workflows/ios.yml
line 10 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
That way we can know if this breaks iOS builds the next time we update rust 😺
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR guarantees that the rust version used by the CI runner is the current stable release.
This change is