Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force update rust on the CI #6025

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Mar 25, 2024

This PR guarantees that the rust version used by the CI runner is the current stable release.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Mar 25, 2024
@buggmagnet buggmagnet requested a review from pinkisemils March 25, 2024 14:11
@buggmagnet buggmagnet self-assigned this Mar 25, 2024
Copy link

linear bot commented Mar 25, 2024

@buggmagnet buggmagnet force-pushed the fix-broken-ios-ci-by-updating-rust-ios-576 branch 2 times, most recently from 2ff078b to 19c8c79 Compare March 25, 2024 14:47
@buggmagnet buggmagnet force-pushed the fix-broken-ios-ci-by-updating-rust-ios-576 branch from b458208 to 15b1113 Compare March 25, 2024 15:59
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


.github/workflows/ios.yml line 10 at r1 (raw file):

      - ios/.swiftformat
      - ios/**/*.swift
      - ios/**/*.xctestplan

We should run these tests if Cargo.toml in the root is upgraded too.

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


.github/workflows/ios.yml line 10 at r1 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

We should run these tests if Cargo.toml in the root is upgraded too.

That way we can know if this breaks iOS builds the next time we update rust 😺

Copy link
Contributor Author

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)


.github/workflows/ios.yml line 10 at r1 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

That way we can know if this breaks iOS builds the next time we update rust 😺

Done.

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit ce9ab55 into main Mar 25, 2024
8 checks passed
@buggmagnet buggmagnet deleted the fix-broken-ios-ci-by-updating-rust-ios-576 branch March 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants